fix: add @types/node as an optional peer dependency
#10757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built bundle of Vite starts with a reference to `node` types: https://unpkg.com/browse/vite@3.2.2/dist/node/index.d.ts This means those who depend on Vite type definitions should install `@types/node` in their projects to successfully do type-checking. In that sense, `@types/node` is an optional peer dependency of Vite. After this being fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on `@types/node` *should* be erroneous. The ecosystem CI shouldn't cover that error for downstream packages.
bluwy
approved these changes
Nov 2, 2022
sapphi-red
approved these changes
Nov 3, 2022
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The built bundle of Vite starts with a reference to
nodetypes: https://unpkg.com/browse/vite@3.2.2/dist/node/index.d.tsThis means those who depend on Vite type definitions should install
@types/nodein their projects to do type-checking successfully. In that sense,@types/nodeis an optional peer dependency of Vite.After this is fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on
@types/nodeshould be erroneous. The ecosystem CI shouldn't cover that error for downstream packages.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).