fix(esbuild): handle inline sourcemap option #11120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p3-minor-bug
sapphi-red
approved these changes
Nov 29, 2022
bluwy
added a commit
that referenced
this pull request
Dec 5, 2022
patak-dev
pushed a commit
that referenced
this pull request
Dec 5, 2022
* fix: glob import parsing (#10949) (#11056) closes #10949 closes #11051 * fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958) Co-authored-by: bluwy <bjornlu.dev@gmail.com> fix #8663 * fix(esbuild): handle inline sourcemap option (#11120) * fix(importGlob): preserve line count for sourcemap (#11122) * fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123) * fix: reset global regex before match (#11132) * chore: fix test Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: julienv3 <julienv3@gmail.com> Co-authored-by: 翠 / green <green@sapphi.red>
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When passing
sourcemap: 'inline'totransformWithEsbuildoptions,esbuildreturnsresult.map = ''but we're trying toJSON.parseit which fails.This PR skips
JSON.parsefor inline sourcemapAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).