Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(worker): correct sourcemap boundary after injecting env #14277

Merged
merged 2 commits into from
Sep 8, 2023
Merged

test(worker): correct sourcemap boundary after injecting env #14277

merged 2 commits into from
Sep 8, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Sep 4, 2023

Description

refs #14216

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@sun0day sun0day requested review from patak-dev and bluwy September 7, 2023 05:49
@bluwy bluwy merged commit ab5c421 into vitejs:main Sep 8, 2023
Gaubee pushed a commit to Gaubee/vite that referenced this pull request Sep 13, 2023
@sun0day @Gaubee
test(worker): correct sourcemap boundary after injecting env (vitejs#…
517cac8 
…14277)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sun0day @patak-dev @bluwy