fix: worker build #14614
Closed
fix: worker build #14614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have multiple workers, the config cannot be used as web map key since the config can mutate. Since we're not in a multi-thread environment we can use a fixed key to store the promise of the current worker build. You can use the reproduction provided in vitejs#13367 , when building the third worker, there is a pending promise since the config changes and there is no way to delete it and then the error.
patak-dev
reviewed
Oct 13, 2023
| const workerConfigSemaphore = new WeakMap< | ||
| ResolvedConfig, | ||
| typeof workerKey, |
There was a problem hiding this comment.
After this change, the semaphore would be global and could be replaced by a direct variable to the Promise<OutputChunk>. But AFAICS, this shouldn't fix the issue in general, it should make it happen more stable.
I think we need something like: #14113 for this to work.
There was a problem hiding this comment.
yeah, we need another solution... closing this
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have multiple workers, the config cannot be used as weak map key since the config can mutate.
Since we're not in a multi-thread environment we can use a fixed key to store the promise of the current worker build.
You can use the reproduction provided in #13367 , when building the third worker, there is a pending promise since the config changes and there is no way to delete it and then the error.
closes #13367
Description
check #13367
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).