Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: don't pretransform classic script links #15361

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: don't pretransform classic script links #15361

merged 1 commit into from
Dec 22, 2023

Conversation

sapphi-red
Copy link
Member

Description

fixes #15354
refs #15355

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) regression The issue only appears after a new release labels Dec 15, 2023
@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red linked an issue Dec 19, 2023 that may be closed by this pull request
Vite ignoring external files during Pre-transform #15374
Closed
@sapphi-red sapphi-red removed a link to an issue Dec 21, 2023
Vite ignoring external files during Pre-transform #15374
Closed
@bluwy bluwy merged commit 19e3c9a into vitejs:main Dec 22, 2023
9 checks passed
@sapphi-red sapphi-red deleted the fix/dont-pretransform-classic-script-links branch December 30, 2023 12:37
@Mousaka Mousaka mentioned this pull request Jan 19, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary errors for public js libs in index.html
3 participants
@sapphi-red @patak-dev @bluwy