Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(legacy): emit css assets when cssCodeSplit and modernChuns is off #16125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

armano2
Copy link

@armano2 armano2 commented Mar 8, 2024

Description

This change allows assets to be emitted when renderModernChunks is set to false
i noticed this issue when i tried using cssCodeSplit: false with renderModernChunks: false

Additional context

Partially fixes issue #2062 #5901


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Mar 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@armano2 armano2 changed the title fix(legacy): emit css assets when no cssCodeSplit and modernChuns are off fix(legacy): emit css assets when cssCodeSplit and modernChuns is off Apr 23, 2024
@armano2
Copy link
Author

armano2 commented Jul 30, 2024

@patak-dev is there anything else that i have to do here?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant