-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(create-vite): use @clack/prompts
#19445
base: main
Are you sure you want to change the base?
Conversation
Looks like it's failing on windows CI as there's an error happening for non-tty terminals. There's an upstream issue for this: bombshell-dev/clack#192 I guess it's kinda a blocker now that some windows user wouldn't be able to run Error message
Particularly it's erroring on this line |
Nice ✨ I pushed a patch that fixes the error on Windows (it reproduced on my machine). I'll make a PR upstream later on. I'm not sure if this fixes the Git bash case as that one didn't reproduce on my machine. It worked with powershell / cmd / git bash for me. |
I think this looks great! Awesome that all the options are visible again. |
Thanks for fixing it on windows! I wouldn't be able to figure it out myself. |
Description
Here's a video of me testing out the CLI:
clack-record.mp4
NOTE: I cmd+c during executing the react-router cli as it was taking a bit long. But it was working when testing manually.
I also fixed the
--overwrite
flag support as the overwrite option is now a 3-option select rather than a boolean. (feature added in #15808). I also replacedminimist
withmri
.dist/index.mjs
size:Other improvements:
Since
@clack/prompts
is more imperative, we could also add additional step messages likeusing xxx template
(if--template
is passed), orfiles in xxx removed
(if--overwrite
is passed), etc. But I've kept the prompts as close to as before for now.