Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update dependency slash to v4 #4118

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 5, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
slash ^3.0.0 -> ^4.0.0 age adoption passing confidence

Release Notes

sindresorhus/slash

v4.0.0

Compare Source

Breaking

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Jul 5, 2021
Shinigami92
Shinigami92 previously approved these changes Jul 5, 2021
@Shinigami92 Shinigami92 requested a review from patak-dev July 6, 2021 15:42
@patak-dev patak-dev merged commit 6017ddb into main Jul 30, 2021
@patak-dev patak-dev deleted the renovate/slash-4.x branch July 30, 2021 11:21
@yyx990803
Copy link
Member

yyx990803 commented Aug 5, 2021

Hmm... this actually breaks plugin-vue's dev mode since slash 4 is "type": "module" and can no longer be required. It passes on CI because during CI we bundle plugin-vue with esbuild. This should be reverted (at least for now)

patak-dev added a commit that referenced this pull request Aug 5, 2021
patak-dev added a commit that referenced this pull request Aug 5, 2021
@patak-dev
Copy link
Member

@yyx990803 done, luckily AFAICS this wasn't included in a release https://github.com/vitejs/vite/commits/main/packages/plugin-vue

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants