Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(create-vite): use reset for prompts for white bg color shell #6131

Merged
merged 1 commit into from
Jan 17, 2022
Merged

fix(create-vite): use reset for prompts for white bg color shell #6131

merged 1 commit into from
Jan 17, 2022

Conversation

userquin
Copy link
Contributor

closes #6130

@userquin
Copy link
Contributor Author

userquin commented Dec 15, 2021 •
edited
Loading

The result for white:

imagen

and on black:

imagen

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 16, 2021
@userquin
Copy link
Contributor Author

userquin commented Dec 16, 2021 •
edited
Loading

don't merge yet, I'm adding a feature request to prompts and maybe a PR.

EDIT: terkelg/prompts#345

@userquin
Copy link
Contributor Author

PR sent: terkelg/prompts#346

@userquin userquin marked this pull request as draft December 16, 2021 17:48
@userquin
Copy link
Contributor Author

Closing this, my PR merged on prompts repo, when released just update dep here.

@userquin userquin closed this Dec 21, 2021
@userquin userquin deleted the fix/vite-cli-white-shell branch December 21, 2021 00:55
@userquin
Copy link
Contributor Author

Upps, wrong PR, reverting...

@userquin userquin restored the fix/vite-cli-white-shell branch December 21, 2021 00:58
@userquin userquin reopened this Dec 21, 2021
@userquin userquin marked this pull request as ready for review January 17, 2022 18:42
@userquin
Copy link
Contributor Author

I think this can be merged.

@patak-dev patak-dev merged commit dd3bbb8 into vitejs:main Jan 17, 2022
@userquin userquin deleted the fix/vite-cli-white-shell branch January 17, 2022 22:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing entries when using create-vite on shell with white gbcolor
3 participants
@userquin @patak-dev @Shinigami92