Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use strip-literal to strip string lterals #8054

Merged
merged 4 commits into from
May 7, 2022
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented May 7, 2022

Description

Continues #7650

Using regex is impossible to handle this correctly. For example

let a = ['`', "`", `'`, `"`]

While #7650 introduced a lexer for string templates, it does not cover well with mixing quotes.

I made https://github.com/antfu/strip-literal using acron's tokenizer to handle this correctly with the minimal overhead as possible. This also unblockers #7537

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu mentioned this pull request May 7, 2022
4 tasks
poyoho
poyoho previously approved these changes May 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants