Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: fix ssr tests #8313

Merged
merged 1 commit into from
May 24, 2022
Merged

chore: fix ssr tests #8313

merged 1 commit into from
May 24, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 24, 2022

Description

Add page.goto for each tests as custom servers need t manually navigate to it on each test.

Also add networkidle to first ssr-vue test as it triggers vuex optimization, which affects following tests.

Additional context

From #7568 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label May 24, 2022
@patak-dev patak-dev merged commit a0fc01a into vitejs:main May 24, 2022
@bluwy bluwy deleted the chore-fix-ssr-tests branch May 24, 2022 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants