-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(asset): respect assetFileNames if rollupOptions.output is an array #8561
Merged
patak-dev
merged 7 commits into
vitejs:main
from
inkyMountain:fix/respect-assetFileNames
Jun 15, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0996a1b
fix(asset): respect assetFileNames if rollupOptions.output is an arra…
99fab6f
perf(asset): move assetFileNames check to config.ts
f3bd570
chore: fix eslint issues
325c073
chore: fix prettier issues
03409aa
test(legacy): modify multiple output build config
92354a8
fix(asset): modify multiple output assetFileNames config check strategy
b1282d3
chore: update
patak-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import './style.css' | ||
import './vite.svg' | ||
|
||
async function run() { | ||
const { fn } = await import('./async.js') | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import legacy from '@vitejs/plugin-legacy' | ||
import { defineConfig } from 'vite' | ||
|
||
export default defineConfig({ | ||
plugins: [legacy({ modernPolyfills: true })], | ||
build: { | ||
manifest: true, | ||
minify: false, | ||
rollupOptions: { | ||
output: [ | ||
{ | ||
assetFileNames() { | ||
return 'assets/subdir/[name].[hash][extname]' | ||
}, | ||
entryFileNames: `assets/subdir/[name].js`, | ||
chunkFileNames: `assets/subdir/[name].js` | ||
}, | ||
{ | ||
assetFileNames() { | ||
return 'assets/subdir/[name].[hash][extname]' | ||
}, | ||
entryFileNames: `assets/anotherSubdir/[name].js`, | ||
chunkFileNames: `assets/anotherSubdir/[name].js` | ||
} | ||
] | ||
} | ||
} | ||
}) |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the first output configured by the user is a better choice here. Should we consider outputting multiple assets according to array in lib mode? (Maybe it has nothing to related to this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could keep working to improve this later. At least this PR fixes the plugin legacy issue that is very common. So i think we should merge and then work on another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, lib mode is just asset output once. and chunk and entry will output multi bundle