Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Force viur-core and viur-cli Updates on first initialization #160

Conversation

Grashalmbeisser
Copy link
Collaborator

I added some Functionality with which the viur-cli is autochecking for Updates after the First initialization.

@Grashalmbeisser Grashalmbeisser requested review from akelch and sveneberth and removed request for akelch August 28, 2024 12:22
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Grashalmbeisser I don't see the need for all this. If you set the viur-core and viur-cli to a flexible patch level (<= or ~= operator) and occasionally do a pipenv update, you can save yourself all this parsing back and forth here.
Before I start my development server, I don't want to wait until 30000 thousand checks have been run that I can't deactivate. Such a CLI should support the development of and with ViUR, but it should be as compact as necessary. Following the unix philosophy "do one thing and do it well". I already have pipenv, with which I can manage my packages and which does a damn good job -- I don't need a wrapper for that.

Quite apart from the fact that the implementation is so poorly developed. Neither major nor patch level is taken into account here, nor is this a complete workflow. I hardly have any interest in switching to the next major version, which has breaking changes and rewrites data, when starting the development server. Nor does the cli execute any migration scripts afterwards, nor does it regenerate the requirements.txt afterwards or show me the changelog beforehand.

Instead of constantly stuffing this CLI with new features, please make sure that bugs are fixed first.

@phorward phorward changed the title Feature: Force viur-core and viur-cli Updates on first initialization feat: Force viur-core and viur-cli Updates on first initialization Sep 2, 2024
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Grashalmbeisser,

I'm with @sveneberth. Can you please focus on general viur-cli improvement first, and let the developers do the dependency management?

@Grashalmbeisser Grashalmbeisser deleted the feature/forceViURUpdates branch September 20, 2024 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants