Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: ✨ add character length indicator for commit message #310

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: ✨ add character length indicator for commit message #310

wants to merge 14 commits into from

Conversation

gabolera
Copy link

@gabolera gabolera commented Mar 9, 2023

Added count visual characters for help user as not write a big commit

  • Short recommended limit 50
  • Long recommended limit: 72 (maybe this value is wrong and can change)

PR for this discussion #293

Print of feature
Screenshot_27

@gabolera gabolera changed the title add character length indicator for commit message feat: ✨ add character length indicator for commit message Mar 9, 2023
@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 10, 2023
@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Mar 10, 2023
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-e8d25c4.vsix in artifacts. 🚀

@gabolera gabolera mentioned this pull request Mar 10, 2023
Open
@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-dcb7e09.vsix in artifacts. 🚀

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-1c8cfdf.vsix in artifacts. 🚀

@gabolera
feat: ✨ add enums for get value of commitlint for max subject and body
113359d 
add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
@gabolera
refactor: ⚡ add type any for all catch (e) which is undefined
3826ebc 
this modification has solved error in build

 Argument of type 'unknown' is not assignable to parameter of type 'string | Error'
@gabolera gabolera closed this Sep 28, 2023
@gabolera gabolera reopened this Sep 28, 2023
@gabolera
feat: ✨ add function for get value of commitlint for max subject and …
f667daa 
…body

add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
@gabolera
feat: ✨ add function for get value of commitlint for max subject and …
96750c4 
…body

add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
@gabolera
Copy link
Author

gabolera commented Sep 28, 2023 •
edited
Loading

@yi-Xu-0100 @vivaxy You can test?

Context of editions #293 (comment)

#293

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabolera @yi-Xu-0100