TableFilterFinalForm: support all final-form-props #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsams
reviewed
Jul 24, 2019
| // call to render-children consists of ...rest, ...renderProps, __versions, see https://github.com/final-form/react-final-form/blob/master/src/ReactFinalForm.js#L195 | ||
| // whereby ...rest is FormProps destructed with all Config attributes and FormProps specific attributes, see https://github.com/final-form/react-final-form/blob/master/src/ReactFinalForm.js#L42 | ||
| // which left RenderableProps in ...rest. (click FormProps and check extends). But they are missing in FormRenderProps-Type | ||
| export type CorrectFormRenderProps<FormValues = AnyObject> = FormRenderProps<FormValues> & RenderableProps<FormRenderProps<FormValues>>; |
There was a problem hiding this comment.
👍
aber vielleicht fällt dir ein besserer name ein, weil no na ist er korrekt :)
und bitte die datei klein schreiben (ist ja keine komponente)
Ben-Ho
force-pushed
the
forwardFinalFormChildRender
branch
from
035dfcc to
fefdb64
Compare
Ben-Ho
changed the title
Ben-Ho
force-pushed
the
forwardFinalFormChildRender
branch
from
fefdb64 to
e58f1a6
Compare
Ben-Ho
commented
Jul 29, 2019
| // call to render-children consists of ...rest, ...renderProps, __versions, see https://github.com/final-form/react-final-form/blob/master/src/ReactFinalForm.js#L195 | ||
| // whereby ...rest is FormProps destructed with all Config attributes and FormProps specific attributes, see https://github.com/final-form/react-final-form/blob/master/src/ReactFinalForm.js#L42 | ||
| // which left RenderableProps in ...rest. (click FormProps and check extends). But they are missing in FormRenderProps-Type | ||
| export type CorrectFormRenderProps<FormValues = AnyObject> = FormRenderProps<FormValues> & RenderableProps<FormRenderProps<FormValues>>; |
There was a problem hiding this comment.
FormRenderProps are defined wrong in final-form-types package. this is a fix. (I'm going to create a pull-request in types)
There was a problem hiding this comment.
I addressed this missing props in this pull-request: final-form/react-final-form#575
If my pull-request gets merged this type shouldn't be needed anymore.
nsams
approved these changes
Jul 29, 2019
Ben-Ho
force-pushed
the
forwardFinalFormChildRender
branch
from
e58f1a6 to
b4ba860
Compare
implement childRender like done in final-form to fully support mutators and other features which require child-components use onSubmit if set, but that won't be needed as you normally don't submit filter-values.
Ben-Ho
force-pushed
the
forwardFinalFormChildRender
branch
from
b4ba860 to
cdabd9e
Compare
kaufmo
approved these changes
Aug 6, 2019
fraxachun
approved these changes
Aug 6, 2019
nsams
approved these changes
Aug 6, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.