Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[vividus-extension-selenium] Fix regex for locator converter #2028

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

abudevich
Copy link
Contributor

@abudevich abudevich commented Oct 1, 2021

Fixes #1993

@abudevich abudevich self-assigned this Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #2028 (d757743) into master (71dc2d6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2028   +/-   ##
=========================================
  Coverage     96.09%   96.09%           
+ Complexity     5322     5321    -1     
=========================================
  Files           754      754           
  Lines         15167    15162    -5     
  Branches       1029     1028    -1     
=========================================
- Hits          14574    14570    -4     
+ Misses          460      459    -1     
  Partials        133      133           
Impacted Files Coverage Δ
...va/org/vividus/ui/util/LocatorConversionUtils.java 97.36% <ø> (ø)
...org/vividus/bdd/steps/ui/web/WebElementsSteps.java
.../vividus/bdd/steps/ui/web/TextValidationSteps.java 97.87% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71dc2d6...d757743. Read the comment docs.

@valfirst valfirst merged commit d537128 into vividus-framework:master Oct 1, 2021
@abudevich abudevich deleted the 1993-fix-regex branch November 2, 2021 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal visibility type for "When I find ... elements by ... and for each element do..." step with cssSelector
3 participants