Introduce Avro plugin #2152
Merged
Introduce Avro plugin #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
force-pushed
the
add-avro-plugin
branch
from
e0ccf96 to
77f25f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2152 +/- ##
=========================================
Coverage 96.21% 96.21%
- Complexity 5362 5366 +4
=========================================
Files 757 758 +1
Lines 15318 15336 +18
Branches 1031 1030 -1
=========================================
+ Hits 14738 14756 +18
Misses 450 450
Partials 130 130
Continue to review full report at Codecov.
|
uarlouski
reviewed
Nov 7, 2021
ikalinin1
reviewed
Nov 8, 2021
Comment on lines
69
to
71
| LOGGER.atInfo() | ||
| .addArgument(() -> dataFileReader.getSchema().toString(false)) | ||
| .log("Avro schema: {}"); |
There was a problem hiding this comment.
Suggested change
| LOGGER.atInfo() | |
| .addArgument(() -> dataFileReader.getSchema().toString(false)) | |
| .log("Avro schema: {}"); | |
| LOGGER.atInfo() | |
| .addArgument(() -> dataFileReader.getSchema().toString(false)) | |
| .log("Avro schema: {}"); |
ikalinin1
reviewed
Nov 8, 2021
Comment on lines
51
to
54
| Set<VariableScope> scopes = Set.of(VariableScope.STORY); | ||
| String variableName = "varName"; | ||
| avroSteps.convertAvroDataToJson("/event-message.avro", scopes, variableName); | ||
| verify(bddVariableContext).putVariable(scopes, variableName, "[{\"SequenceNumber\": 0, \"Offset\": \"0\", " |
There was a problem hiding this comment.
Suggested change
| Set<VariableScope> scopes = Set.of(VariableScope.STORY); | |
| String variableName = "varName"; | |
| avroSteps.convertAvroDataToJson("/event-message.avro", scopes, variableName); | |
| verify(bddVariableContext).putVariable(scopes, variableName, "[{\"SequenceNumber\": 0, \"Offset\": \"0\", " | |
| var scopes = Set.of(VariableScope.STORY); | |
| var variableName = "varName"; | |
| avroSteps.convertAvroDataToJson("/event-message.avro", scopes, variableName); | |
| verify(bddVariableContext).putVariable(scopes, variableName, "[{\"SequenceNumber\": 0, \"Offset\": \"0\", " |
ikalinin1
reviewed
Nov 8, 2021
| @@ -53,11 +54,12 @@ | |||
| */ | |||
| @When("I create temporary file with name `$name` and content `$content` and put path to $scopes variable" | |||
| + " `$variableName`") | |||
| public void saveResponseBodyToFile(String name, String content, Set<VariableScope> scopes, String variableName) | |||
| public void createTemporaryFile(String name, DataWrapper content, Set<VariableScope> scopes, String variableName) | |||
There was a problem hiding this comment.
could you please add an integration test for the case with binary data
There was a problem hiding this comment.
it's added as a part of Avro test
valfirst
force-pushed
the
add-avro-plugin
branch
from
77f25f2 to
ff3d7ee
Compare
|
SonarCloud Quality Gate failed. |
ikalinin1
approved these changes
Nov 8, 2021
uarlouski
approved these changes
Nov 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.