[plugin-azure-data-factory] Add ability to collect pipeline runs #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=========================================
Coverage 96.22% 96.23%
- Complexity 5380 5384 +4
=========================================
Files 764 764
Lines 15394 15426 +32
Branches 1025 1025
=========================================
+ Hits 14813 14845 +32
Misses 451 451
Partials 130 130
Continue to review full report at Codecov.
|
ikalinin1
reviewed
Nov 16, 2021
| this.filterSetter = filterSetter; | ||
| } | ||
|
|
||
| public void setFilters(RunFilterParameters filterParameters, OffsetDateTime filterValue) |
There was a problem hiding this comment.
setFilters looks confusing, the method is applying a filter to the RunFilterParameters
ikalinin1
approved these changes
Nov 16, 2021
valfirst
force-pushed
the
add-ability-to-collect-pipeline-runs
branch
from
8329f2d to
fd0f11e
Compare
valfirst
force-pushed
the
add-ability-to-collect-pipeline-runs
branch
from
fd0f11e to
4978be0
Compare
uarlouski
approved these changes
Nov 16, 2021
|
Kudos, SonarCloud Quality Gate passed! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.