[extension-selenium] Publish screenshot on failure in step scanning barcode #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #2213 +/- ##
============================================
- Coverage 96.24% 88.22% -8.03%
- Complexity 5394 5569 +175
============================================
Files 766 766
Lines 15465 15468 +3
Branches 1027 1027
============================================
- Hits 14884 13646 -1238
- Misses 451 1683 +1232
- Partials 130 139 +9
Continue to review full report at Codecov.
|
ikalinin1
reviewed
Nov 18, 2021
| bddVariableContext.putVariable(scopes, variableName, result); | ||
| } | ||
| catch (NotFoundException e) | ||
| { | ||
| softAssert.recordFailedAssertion("There is no barcode on the screen", e); | ||
| Attachment attachment = new Attachment(ImageTool.toByteArray(viewportScreenshot), "Viewport Screenshot", |
There was a problem hiding this comment.
Could you please elaborate @TakeScreenshotOnFailure annotating not enough?
There was a problem hiding this comment.
- performance: duplicate operation taking one more screenshot
- timing: the viewport screenshot contains the most relevant application state, if we take screenshot some time later, the state of the application may be changed (e.g. animations)
ikalinin1
approved these changes
Nov 18, 2021
uarlouski
approved these changes
Nov 18, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.