Transfer web proxy steps to extension-selenium #2256

VitaliaPiliuhina · 2021-11-30T13:06:39Z

No description provided.

abudevich · 2021-12-02T06:28:55Z

vividus-extension-selenium/build.gradle

@@ -32,6 +33,11 @@ project.description = 'Vividus extension for selenium'
     implementation(group: 'org.apache.commons', name: 'commons-lang3', version: versions.commonsLang3)
     implementation(group: 'org.springframework', name: 'spring-core', version: versions.spring)

+     // browserup-proxy depends on both netty-all and netty-core, so we need to align versions of all netty dependencies
+     // https://github.com/browserup/browserup-proxy/blob/26714e26fae728733a13a0f332bd0c6dcaa78de5/browserup-proxy-core/build.gradle#L60-L76
+     implementation(group: 'io.netty', name: 'netty-all', version: "${nettyVersion}")


Why don't we write version as for seleniumVersion or browserupProxyVersion ?

valfirst · 2021-12-02T12:58:53Z

vividus-extension-selenium/src/main/java/org/vividus/ui/action/web/IWebWaitActions.java

+import org.openqa.selenium.WebDriver;
+import org.vividus.ui.action.IWaitActions;
+
+public interface IWebWaitActions extends IWaitActions


it shouldn't be moved

valfirst · 2021-12-02T13:03:16Z

docs/modules/plugins/partials/proxy-steps.adoc

+.Validate the URL query of the matching HTTP request
+[source,gherkin]
+----
+Given I am on a page with the URL 'https://www.google.com/search?q=vividus'


these examples are not applicable for mobile apps

{givent-step}

valfirst · 2021-12-02T13:04:30Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

@@ -744,3 +746,5 @@ When I select next value with `0.1` offset in picker wheel located `xpath(//XCUI


 include::partial$generic-ui-steps.adoc[]
+
+include::partial$proxy-steps.adoc[]


we should put some extra info, that proxy is not supported by Appium and custom solutions are needed

codecov · 2021-12-02T22:01:17Z

Codecov Report

Merging #2256 (92c2035) into master (a0778b3) will increase coverage by 8.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2256      +/-   ##
============================================
+ Coverage     87.99%   96.30%   +8.30%     
+ Complexity     5528     5363     -165     
============================================
  Files           762      762              
  Lines         15372    15408      +36     
  Branches       1024     1024              
============================================
+ Hits          13527    14838    +1311     
+ Misses         1713      445    -1268     
+ Partials        132      125       -7

Impacted Files	Coverage Δ
.../java/org/vividus/proxy/model/HttpMessagePart.java	`100.00% <ø> (ø)`
.../main/java/org/vividus/proxy/steps/ProxySteps.java	`100.00% <ø> (ø)`
...idus/selenium/manager/GenericWebDriverManager.java	`98.07% <0.00%> (-0.08%)`	⬇️
...reportportal/config/ReportPortalConfiguration.java	`100.00% <0.00%> (ø)`
...rtal/jbehave/AdaptedReportPortalStoryReporter.java
...eportportal/listener/AssertionFailureListener.java
...eportportal/jbehave/AdaptedReportPortalFormat.java	`100.00% <0.00%> (ø)`
...ve/AdaptedDelegatingReportPortalStoryReporter.java	`100.00% <0.00%> (ø)`
...in/java/org/vividus/configuration/BeanFactory.java	`94.28% <0.00%> (+14.28%)`	⬆️
...rg/vividus/report/allure/event/StatusProvider.java	`57.14% <0.00%> (+17.14%)`	⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0778b3...92c2035. Read the comment docs.

valfirst

Also please make sure the corresponding unit tests are moved as well

valfirst · 2021-12-10T09:44:11Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

 |===

+include::partial$proxy-meta-tags.adoc[]
+
+IMPORTANT: For device configuration, we need to perform the following steps: install CA certificate(download CA certificate from a browserup repository), configure device proxy, and configure the test app to allow proxy in cases of necessity.


please add a link to CA certificate to download

valfirst · 2021-12-10T09:44:39Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

 |===

+include::partial$proxy-meta-tags.adoc[]
+
+IMPORTANT: For device configuration, we need to perform the following steps: install CA certificate(download CA certificate from a browserup repository), configure device proxy, and configure the test app to allow proxy in cases of necessity.


could you please elaborate on "configure device proxy"?

I mean the following steps:

go to the device’s Settings and Wifi configuration

press on the network you’re going to use

tap a Proxy field and select Manual

add a proxy hostname and a proxy port

valfirst · 2021-12-10T09:45:56Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

@@ -1,5 +1,7 @@
 :grid-default-hostname: empty
 :keys: https://github.com/appium/appium-xcuitest-driver#mobile-pressbutton[iOS keys] or https://appium.github.io/java-client/io/appium/java_client/android/nativekey/AndroidKey.html[Android keys]
+:proxy: This step requires proxy to be turned on. It can be done in properties or by switching on @proxy meta tag at the story level.


can it be a part of proxy-steps.adoc?

uarlouski · 2021-12-21T09:46:26Z

docs/modules/plugins/partials/proxy-properties.adoc

+|Overrides the host which will be used by proxy
+
+|proxy.ports
+|10000-10005


can't it be any port from not reserved/registered range i.e. 49152 to 65535?

just wondering why 10000-10005

valfirst

Please resolve conflicts at first

…ork#2252) Bumps [vividus-build-system](https://github.com/vividus-framework/vividus-build-system) from `7850e3c` to `ca2a0c3`. - [Release notes](https://github.com/vividus-framework/vividus-build-system/releases) - [Commits](vividus-framework/vividus-build-system@7850e3c...ca2a0c3) --- updated-dependencies: - dependency-name: vividus-build-system dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

valfirst · 2021-12-22T11:08:31Z

.github/workflows/gradle.yml

+                                                  -Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-ios.zip \
+                                                  -Pvividus.statistics.print-failures=true


Suggested change

-Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-ios.zip \

-Pvividus.statistics.print-failures=true

-Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-ios.zip

valfirst · 2021-12-22T11:09:24Z

.github/workflows/gradle.yml

+                                                  -Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-android.zip \
+                                                  -Pvividus.statistics.print-failures=true


Suggested change

-Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-android.zip \

-Pvividus.statistics.print-failures=true

-Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-android.zip

valfirst · 2021-12-22T11:15:58Z

vividus-extension-selenium/build.gradle

@@ -3,6 +3,7 @@ project.description = 'Vividus extension for selenium'
 ext {
     seleniumVersion = '4.1.1'
     browserupProxyVersion = '2.1.2'
+     nettyVersion = '4.1.70.Final'


https://github.com/vividus-framework/vividus/blob/master/vividus-plugin-web-app/build.gradle#L5

also should the same dependencies be removed from vividus-plugin-web-app?

ikalinin1 · 2021-12-22T14:09:26Z

.github/workflows/gradle.yml

+            ./gradlew :vividus-tests:debugStories -Pvividus.configuration.environments=system/saucelabs/mobile_app/ios \
+                                                  -Pvividus.configuration.suites= \
+                                                  -Pvividus.configuration.profiles=saucelabs/mobile_app,mobile_app/ios \
+                                                  -Pvividus.bdd.story-loader.batch-1.resource-location=story/integration \


the story location is incorrect

ikalinin1 · 2021-12-22T14:09:54Z

.github/workflows/gradle.yml

+            ./gradlew :vividus-tests:debugStories -Pvividus.configuration.environments=system/saucelabs/mobile_app/android \
+                                                  -Pvividus.configuration.suites= \
+                                                  -Pvividus.configuration.profiles=saucelabs/mobile_app,mobile_app/android \
+                                                  -Pvividus.bdd.story-loader.batch-1.resource-location=story/integration \


https://github.com/vividus-framework/vividus/pull/2256/files#r773914257

vividus-extension-selenium/build.gradle

.github/workflows/gradle.yml

VitaliaPiliuhina force-pushed the web-proxy-steps-to-extension-selenium branch from bb9cf30 to cb7d365 Compare December 1, 2021 08:21

ikalinin1 requested review from valfirst, uarlouski, ikalinin1 and abudevich December 1, 2021 14:20

abudevich reviewed Dec 2, 2021

View reviewed changes

valfirst requested changes Dec 2, 2021

View reviewed changes

valfirst reviewed Dec 2, 2021

View reviewed changes

valfirst requested changes Dec 10, 2021

View reviewed changes

VitaliaPiliuhina requested a review from valfirst December 16, 2021 08:21

VitaliaPiliuhina force-pushed the web-proxy-steps-to-extension-selenium branch from 91f794b to ac4cfe6 Compare December 16, 2021 11:25

ikalinin1 requested a review from abudevich December 21, 2021 09:23

uarlouski reviewed Dec 21, 2021

View reviewed changes

valfirst requested changes Dec 21, 2021

View reviewed changes

VitaliaPiliuhina force-pushed the web-proxy-steps-to-extension-selenium branch from 6459c43 to 4c03bea Compare December 21, 2021 11:40

VitaliaPiliuhina requested review from uarlouski and valfirst December 22, 2021 09:22

valfirst requested changes Dec 22, 2021

View reviewed changes

ikalinin1 reviewed Dec 22, 2021

View reviewed changes

valfirst reviewed Dec 23, 2021

View reviewed changes

vividus-extension-selenium/build.gradle Outdated Show resolved Hide resolved

Transfer proxy steps to extension-selenium

e614a64

VitaliaPiliuhina force-pushed the web-proxy-steps-to-extension-selenium branch from a83af3e to e614a64 Compare December 23, 2021 12:20

valfirst approved these changes Dec 23, 2021

View reviewed changes

valfirst requested a review from ikalinin1 December 23, 2021 12:51

Fix SAUCELABS_USER name

1e1f510

uarlouski approved these changes Dec 23, 2021

View reviewed changes

ikalinin1 reviewed Dec 24, 2021

View reviewed changes

.github/workflows/gradle.yml Outdated Show resolved Hide resolved

Fix android proxy publishing

92c2035

ikalinin1 approved these changes Dec 24, 2021

View reviewed changes

valfirst merged commit 0c7a68f into vividus-framework:master Dec 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transfer web proxy steps to extension-selenium #2256

Transfer web proxy steps to extension-selenium #2256

VitaliaPiliuhina commented Nov 30, 2021

abudevich Dec 2, 2021

valfirst Dec 2, 2021

valfirst Dec 2, 2021

ikalinin1 Dec 7, 2021

valfirst Dec 2, 2021

codecov bot commented Dec 2, 2021 •

edited

Loading

valfirst left a comment

valfirst Dec 10, 2021

valfirst Dec 10, 2021

VitaliaPiliuhina Dec 15, 2021

valfirst Dec 10, 2021

uarlouski Dec 21, 2021

uarlouski Dec 21, 2021

valfirst left a comment

valfirst Dec 22, 2021

valfirst Dec 22, 2021

valfirst Dec 22, 2021

valfirst Dec 22, 2021

ikalinin1 Dec 22, 2021

ikalinin1 Dec 22, 2021

		@@ -744,3 +746,5 @@ When I select next value with `0.1` offset in picker wheel located `xpath(//XCUI


		include::partial$generic-ui-steps.adoc[]

		include::partial$proxy-steps.adoc[]

		-Pvividus.bdd.variables.global.app-url=sauce-storage:vividus-test-app-ios.zip \
		-Pvividus.statistics.print-failures=true

Transfer web proxy steps to extension-selenium #2256

Transfer web proxy steps to extension-selenium #2256

Conversation

VitaliaPiliuhina commented Nov 30, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 2, 2021 • edited Loading

Codecov Report

valfirst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

valfirst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 2, 2021 •

edited

Loading