Rp #2300
Merged
Rp #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2300 +/- ##
============================================
+ Coverage 88.00% 88.03% +0.02%
- Complexity 5544 5554 +10
============================================
Files 762 762
Lines 15403 15439 +36
Branches 1033 1033
============================================
+ Hits 13556 13592 +36
Misses 1712 1712
Partials 135 135
Continue to review full report at Codecov.
|
valfirst
requested changes
Dec 17, 2021
...c/main/java/org/vividus/reportportal/jbehave/AdaptedDelegatingReportPortalStoryReporter.java
Outdated
Show resolved
Hide resolved
vividus-agent-reportportal/src/main/resources/properties/defaults/default.properties
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Dec 20, 2021
valfirst
reviewed
Dec 20, 2021
...c/main/java/org/vividus/reportportal/jbehave/AdaptedDelegatingReportPortalStoryReporter.java
Outdated
Show resolved
Hide resolved
valfirst
reviewed
Dec 20, 2021
| implementation project(':vividus-soft-assert') | ||
| implementation project(':vividus-reporter') | ||
| implementation(group: 'com.google.guava', name: 'guava', version: versions.guava) | ||
| implementation(group: 'org.springframework', name: 'spring-context', version: versions.spring) | ||
|
|
||
| // ReportPortal | ||
| implementation(group: 'com.epam.reportportal', name: 'logger-java-log4j', version: '4.0.2') | ||
| implementation(group: 'com.github.reportportal', name: 'agent-java-jbehave', version: '4.2.1') { | ||
| implementation(group: 'com.epam.reportportal', name: 'logger-java-log4j', version: '5.1.2') |
There was a problem hiding this comment.
Suggested change
| implementation(group: 'com.epam.reportportal', name: 'logger-java-log4j', version: '5.1.2') | |
| implementation(group: 'com.epam.reportportal', name: 'logger-java-log4j', version: '5.1.3') |
welcome to log4jhell
valfirst
approved these changes
Dec 21, 2021
uarlouski
reviewed
Dec 21, 2021
...c/main/java/org/vividus/reportportal/jbehave/AdaptedDelegatingReportPortalStoryReporter.java
Outdated
Show resolved
Hide resolved
valfirst
approved these changes
Dec 21, 2021
|
Kudos, SonarCloud Quality Gate passed! |
uarlouski
approved these changes
Dec 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.