Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[plugin-mobile-app] Add steps to interact with sliders #2377

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

uarlouski
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2377 (1bf906d) into master (e5e0fce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2377   +/-   ##
=========================================
  Coverage     96.36%   96.36%           
- Complexity     5411     5420    +9     
=========================================
  Files           770      770           
  Lines         15531    15547   +16     
  Branches       1035     1037    +2     
=========================================
+ Hits          14966    14982   +16     
  Misses          441      441           
  Partials        124      124           
Impacted Files Coverage Δ
...java/org/vividus/mobileapp/steps/ElementSteps.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e0fce...1bf906d. Read the comment docs.

@uarlouski uarlouski force-pushed the slider branch 7 times, most recently from 7366767 to 7f7b9fb Compare January 17, 2022 14:58
@vividus-framework vividus-framework deleted a comment from sonarqubecloud bot Jan 17, 2022
@vividus-framework vividus-framework deleted a comment from sonarqubecloud bot Jan 19, 2022
@vividus-framework vividus-framework deleted a comment from sonarqubecloud bot Jan 19, 2022
@uarlouski uarlouski changed the title [plugin-mobile-app] Add step to set slider value [plugin-mobile-app] Add steps to interact with sliders Jan 19, 2022
@uarlouski uarlouski marked this pull request as ready for review January 19, 2022 10:04
Then `${sliderState}` is equal to `38.0`
When I set value of Android slider located `accessibilityId(eighteenToSixtyFiveSlider)` to `2.0`
When I save `${value-attribute}` attribute value of element located `accessibilityId(eighteenToSixtyFiveSliderPosition)` to scenario variable `sliderState`
Then `${sliderState}` is equal to `20.0`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about moving repeating steps to scenario with ExamplesTable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to make scenarios more less generic, so if we decide to move the into some TMS there won't be a question how we get this particular screen, actually I wanted to move this logic into composites, what do you think?

When I set value of iOS slider located `accessibilityId(eighteenToSixtyFiveSlider)` to `80` percent
When I save `${value-attribute}` attribute value of element located `accessibilityId(eighteenToSixtyFiveSliderPosition)` to scenario variable `sliderState`
Then `${sliderState}` is greater than or equal to `52`
Then `${sliderState}` is less than or equal to `58`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about moving repeating steps to scenario with ExamplesTable?

@uarlouski uarlouski force-pushed the slider branch 2 times, most recently from 9918afc to 359a153 Compare January 19, 2022 12:48
@valfirst valfirst self-requested a review January 19, 2022 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 041754b into master Jan 19, 2022
@valfirst valfirst deleted the slider branch January 19, 2022 15:55
VitaliaPiliuhina pushed a commit to VitaliaPiliuhina/vividus that referenced this pull request Apr 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants