Add workaround for CBT integration #2430

valfirst · 2022-01-30T21:52:39Z

…tory`

valfirst · 2022-01-30T21:53:31Z

vividus-extension-selenium/src/main/resources/properties/defaults/default.properties

@@ -23,3 +23,5 @@ proxy.trust-all-servers=false
 proxy.ports=0

 ui.screenshot.debug-directory=
+
+selenium.grid.use-w3c=true


the documentation is skipped on purpose, users shouldn't use this property

codecov · 2022-01-30T22:08:39Z

Codecov Report

Merging #2430 (1e165b2) into master (a2057b6) will decrease coverage by 8.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2430      +/-   ##
============================================
- Coverage     96.46%   88.02%   -8.45%     
- Complexity     5440     5619     +179     
============================================
  Files           772      772              
  Lines         15664    15667       +3     
  Branches       1046     1047       +1     
============================================
- Hits          15111    13791    -1320     
- Misses          430     1745    +1315     
- Partials        123      131       +8

Impacted Files	Coverage Δ
...a/org/vividus/selenium/RemoteWebDriverFactory.java	`100.00% <100.00%> (ø)`
vividus/src/main/java/org/vividus/model/Node.java	`0.00% <0.00%> (-100.00%)`	⬇️
...vidus/src/main/java/org/vividus/model/Failure.java	`0.00% <0.00%> (-100.00%)`	⬇️
...s/src/main/java/org/vividus/model/NodeContext.java	`0.00% <0.00%> (-100.00%)`	⬇️
.../src/main/java/org/vividus/log/TestInfoLogger.java	`0.00% <0.00%> (-100.00%)`	⬇️
...rc/main/java/org/vividus/transformer/JoinMode.java	`0.00% <0.00%> (-100.00%)`	⬇️
...c/main/java/org/vividus/transformer/MergeMode.java	`0.00% <0.00%> (-100.00%)`	⬇️
.../main/java/org/vividus/runner/BddStepsCounter.java	`0.00% <0.00%> (-100.00%)`	⬇️
...n/java/org/vividus/runner/BddScenariosCounter.java	`0.00% <0.00%> (-100.00%)`	⬇️
...n/java/org/vividus/runner/KnownIssueValidator.java	`0.00% <0.00%> (-100.00%)`	⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2057b6...1e165b2. Read the comment docs.

uarlouski · 2022-01-31T06:16:26Z

vividus-extension-selenium/src/main/java/org/vividus/selenium/RemoteWebDriverFactory.java

+        // Selenium 4 declares that it only supports W3C and nevertheless still writes  JWP's "desiredCapabilities" into
+        // "createSession" JSON. Appium Java client eliminates that: https://github.com/appium/java-client/pull/1537.
+        // But still some clouds (e.g. SmartBear CrossBrowserTesting) are not prepared for W3c, so we should avoid
+        // using Appium drivers to create sessions for web tests.
