[engine] Add ability to load aliases from resources #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2492 +/- ##
=========================================
Coverage 96.59% 96.59%
- Complexity 5474 5475 +1
=========================================
Files 774 774
Lines 15748 15750 +2
Branches 1043 1043
=========================================
+ Hits 15211 15213 +2
Misses 414 414
Partials 123 123
Continue to review full report at Codecov.
|
uarlouski
force-pushed
the
jbehave-5-0-0-alpha-25
branch
from
37ba59f to
0e9f3aa
Compare
uarlouski
force-pushed
the
jbehave-5-0-0-alpha-25
branch
from
0e9f3aa to
b62d3a1
Compare
valfirst
requested changes
Feb 16, 2022
vividus-engine/src/main/resources/org/vividus/engine/spring.xml
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/Aliases.story
Outdated
Show resolved
Hide resolved
vividus-tests/src/main/resources/story/integration/Aliases.story
Outdated
Show resolved
Hide resolved
ikalinin1
reviewed
Feb 17, 2022
| Scenario: Verify aliases loaded from resources | ||
|
|
||
| !-- Vividus step | ||
| Then `1` matches `\d+` |
There was a problem hiding this comment.
is it possible to use a different language as an alias? f
There was a problem hiding this comment.
some adjustment will be required
https://jbehave.org/reference/latest/stories-in-your-language.html
There was a problem hiding this comment.
Does it make sense to create an issue for this? @valfirst @uarlouski
uarlouski
force-pushed
the
jbehave-5-0-0-alpha-25
branch
from
b62d3a1 to
7fb6a38
Compare
uarlouski
force-pushed
the
jbehave-5-0-0-alpha-25
branch
from
7fb6a38 to
e26d7e6
Compare
ikalinin1
approved these changes
Feb 18, 2022
valfirst
approved these changes
Feb 18, 2022
|
Kudos, SonarCloud Quality Gate passed! |
VitaliaPiliuhina
pushed a commit
to VitaliaPiliuhina/vividus
that referenced
this pull request
Apr 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.