[plugin-web-app-to-rest-api] Filter invalid jump links from context resource validation #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Jan 29, 2024
...ugin-web-app-to-rest-api/src/main/java/org/vividus/steps/integration/ResourceCheckSteps.java
Outdated
Show resolved
Hide resolved
draker94
force-pushed
the
do_not_validate_jump_links_in_context
branch
2 times, most recently
from
d5b6a37 to
55973c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4760 +/- ##
============================================
- Coverage 97.40% 89.21% -8.19%
- Complexity 6577 6822 +245
============================================
Files 916 918 +2
Lines 18935 18964 +29
Branches 1263 1265 +2
============================================
- Hits 18443 16919 -1524
- Misses 385 1917 +1532
- Partials 107 128 +21 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Jan 30, 2024
...ugin-web-app-to-rest-api/src/main/java/org/vividus/steps/integration/ResourceCheckSteps.java
Outdated
Show resolved
Hide resolved
vividus-plugin-html/src/main/java/org/vividus/html/HtmlLocatorType.java
Outdated
Show resolved
Hide resolved
…esource validation
draker94
force-pushed
the
do_not_validate_jump_links_in_context
branch
from
55973c5 to
5236744
Compare
valfirst
approved these changes
Jan 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4736