[azure-cosmos-db] Add ability to use credentials instead of token for access to DB #4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4783 +/- ##
============================================
- Coverage 97.41% 97.40% -0.01%
- Complexity 6587 6826 +239
============================================
Files 918 918
Lines 18964 18986 +22
Branches 1265 1269 +4
============================================
+ Hits 18474 18494 +20
- Misses 384 385 +1
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Feb 1, 2024
vividus-plugin-azure-cosmos-db/src/main/java/org/vividus/azure/cosmos/CosmosDbService.java
Outdated
Show resolved
Hide resolved
abudevich
force-pushed
the
azure-cosmos-rba
branch
2 times, most recently
from
26ff75a to
3004428
Compare
valfirst
reviewed
Feb 2, 2024
vividus-plugin-azure-cosmos-db/src/main/java/org/vividus/azure/cosmos/CosmosDbService.java
Outdated
Show resolved
Hide resolved
valfirst
reviewed
Feb 2, 2024
vividus-plugin-azure-cosmos-db/src/main/java/org/vividus/azure/cosmos/CosmosDbService.java
Show resolved
Hide resolved
abudevich
force-pushed
the
azure-cosmos-rba
branch
2 times, most recently
from
3ffe2ee to
01579b9
Compare
abudevich
changed the title
valfirst
reviewed
Feb 2, 2024
vividus-plugin-azure-cosmos-db/src/main/java/org/vividus/azure/cosmos/CosmosDbService.java
Show resolved
Hide resolved
abudevich
force-pushed
the
azure-cosmos-rba
branch
from
01579b9 to
760a2f6
Compare
valfirst
reviewed
Feb 2, 2024
Comment on lines
75
to
76
| [IMPORTANT] | ||
| In case if `account-key` was not provided in properties, will be used https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/identity/azure-identity#defaultazurecredential[DefaultAzureCredential mechanism] for authentication. |
There was a problem hiding this comment.
- put this info to the place where
keyis defined - reuse this partial: https://github.com/vividus-framework/vividus/blob/master/docs/modules/plugins/partials/azure-authentication.adoc (feel free to improve it if needed)
abudevich
force-pushed
the
azure-cosmos-rba
branch
2 times, most recently
from
7ac1db5 to
8ef7784
Compare
valfirst
approved these changes
Feb 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.