Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ability to define format for indices of story-level Examples #4823

Conversation

valfirst
Copy link
Collaborator

Closes #4822

@valfirst valfirst requested a review from a team as a code owner February 14, 2024 09:11
@valfirst valfirst force-pushed the add-ability-to-define-pattern-for-indicies-of-story-level-examples branch from d507b9b to cd1c93f Compare February 14, 2024 09:14
@valfirst valfirst changed the title Add ability to define pattern for indicies of story-level Examples Add ability to define format for indicies of story-level Examples Feb 14, 2024
@valfirst valfirst force-pushed the add-ability-to-define-pattern-for-indicies-of-story-level-examples branch from cd1c93f to b446a1c Compare February 14, 2024 09:15
Copy link

github-actions bot commented Feb 14, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@@ -92,6 +92,48 @@ NOTE: The properties marked with *bold* are mandatory.
|`PT2H`
|The max duration of the single story in {durations-format-link} format. Could be overriden via corresponging batch setting.

|`story.example-index-format`
|`\u0020[0]`
a|The format defining how to display indicies of story-level xref:ROOT:glossary.adoc#_examplestable[ExamplesTable] rows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a|The format defining how to display indicies of story-level xref:ROOT:glossary.adoc#_examplestable[ExamplesTable] rows
a|The format defining how to display indices of story-level xref:ROOT:glossary.adoc#_examplestable[ExamplesTable] rows

before and after the equal sign are ignored in properties files.

{java-api-docs-base-url}/docs/api/java.base/java/text/DecimalFormat.html#special_pattern_character[Special format chracters],
e.g., `0`, `#`, specify the way indecies are diplayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g., `0`, `#`, specify the way indecies are diplayed.
e.g., `0`, `#`, specify the way indices are displayed.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (340a35d) 97.36% compared to head (491cd0b) 97.37%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4823      +/-   ##
============================================
+ Coverage     97.36%   97.37%   +0.01%     
+ Complexity     6814     6579     -235     
============================================
  Files           917      917              
  Lines         19016    19016              
  Branches       1267     1267              
============================================
+ Hits          18515    18517       +2     
+ Misses          393      392       -1     
+ Partials        108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst valfirst force-pushed the add-ability-to-define-pattern-for-indicies-of-story-level-examples branch from b446a1c to 82143d9 Compare February 14, 2024 11:34
@valfirst valfirst requested a review from draker94 February 14, 2024 12:46
@valfirst valfirst changed the title Add ability to define format for indicies of story-level Examples Add ability to define format for indices of story-level Examples Feb 14, 2024
before and after the equal sign are ignored in properties files.

{java-api-docs-base-url}/docs/api/java.base/java/text/DecimalFormat.html#special_pattern_character[Special format chracters],
e.g., `0`, `#`, specify the way indices are diplayed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
e.g., `0`, `#`, specify the way indices are diplayed.
e.g., `0`, `#`, specify the way indices are displayed.

?

@valfirst valfirst force-pushed the add-ability-to-define-pattern-for-indicies-of-story-level-examples branch from 82143d9 to 491cd0b Compare February 14, 2024 13:47
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@valfirst valfirst merged commit afbedfa into master Feb 14, 2024
10 checks passed
@valfirst valfirst deleted the add-ability-to-define-pattern-for-indicies-of-story-level-examples branch February 14, 2024 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to sort stories in Allure report by index
3 participants