[plugin-web-app-to-rest-api] Quietly handle non-encoded Sitemap URLs by FROM_SITEMAP transformer
#5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by `FROM_SITEMAP` transformer According to standard all Sitemap URLs must be URL-escaped and encoded (https://www.sitemaps.org/protocol.html#escaping), but there could be cases when production contains invalid URLs and it's needed to crawl websites, so FROM_SITEMAP transformer must be able to handle such invalid URLs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5050 +/- ##
=========================================
Coverage 97.39% 97.39%
- Complexity 6856 6858 +2
=========================================
Files 921 921
Lines 19195 19197 +2
Branches 1270 1270
=========================================
+ Hits 18695 18697 +2
Misses 390 390
Partials 110 110 ☔ View full report in Codecov by Sentry. |
|
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
valfirst
deleted the
quietly-handle-non-encoded-sitemap-urls-by-from-sitemap-transformer
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to standard all Sitemap URLs must be URL-escaped and encoded (https://www.sitemaps.org/protocol.html#escaping), but there could be cases when production contains invalid URLs and it's needed to crawl websites, so FROM_SITEMAP transformer must be able to handle such invalid URLs.