Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[allure-adaptor] Add ability to configure report layout #5423

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Oct 4, 2024

No description provided.

@valfirst valfirst requested a review from a team as a code owner October 4, 2024 15:37
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (5f2d873) to head (6843fa3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rg/vividus/report/allure/plugin/DynamicPlugin.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5423   +/-   ##
=========================================
  Coverage     97.63%   97.64%           
- Complexity     7005     7015   +10     
=========================================
  Files           969      971    +2     
  Lines         20338    20365   +27     
  Branches       1330     1331    +1     
=========================================
+ Hits          19858    19885   +27     
  Misses          368      368           
  Partials        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 4, 2024

Qodana for JVM

7 new problems were found

Inspection name Severity Problems
Incorrect Spring Core XML-based application context 🔴 Failure 4
Incorrect constructor injection in XML Spring bean 🔴 Failure 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

sonarqubecloud bot commented Oct 4, 2024

a|`true` +
`false`
|`true`
|Show or hide menu:Suites[] (aka menu:Batches[]) tab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Is this expected format of messages (I about '[]') ?
Shouldn't we add spaces after the colon?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is, rendering is not correct without square brackets and no space is expected after colon: https://docs.asciidoctor.org/asciidoc/latest/macros/ui-macros/

@valfirst valfirst merged commit 09de3d4 into master Oct 5, 2024
11 checks passed
@valfirst valfirst deleted the add-ability-to-configure-report-layout branch October 5, 2024 11:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants