Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for Rails 4 and create some documentation #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

paladini
Copy link

We already talked about that in "Issues". Basically this pull request give to this gem Rails 4.0 support - and some documentation was created too.

@vivrass
Copy link
Owner

vivrass commented Jan 23, 2014

You code seams good. I won't test it since I don't have any project to test it on.

Some comments:

  1. You should have only 2 commits (1 for the fix, 1 for the documentation). Use "git rebase -i" to merge your commits together. The history of the project will stay cleaner.
  2. I intended to give you the project by adding a Note in the documentation which points to your fork. In the end, I won't accept your pull request since you'll have the new master repo.

@paladini
Copy link
Author

Thanks for your comments, I will do that.

But I didn't know if the best thing is make my repository as the "official". I don't know about how this gem works and even know all methods / all this gem can do. Sincerely, I prefer to maintain your gem as "official", but if you really don't want that, I can stay with my repo. (After you accept the pull request I wanted delete my repo).

Seriously, you decides. I will do what you said and I'm here if you want continue mainteining this gem. Again, thanks. Soon I come back here with the tips of your comment fixed.

@tchak
Copy link

tchak commented May 14, 2014

any updates on this ? I just found your fork @paladini. Sorry for the noise.

@paladini
Copy link
Author

You can check my new Repo, supporting Rails 4, here: https://github.com/paladini/models-to-sql-rails

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants