-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for Rails 4 and create some documentation #2
base: master
Are you sure you want to change the base?
Conversation
You code seams good. I won't test it since I don't have any project to test it on. Some comments:
|
Thanks for your comments, I will do that. But I didn't know if the best thing is make my repository as the "official". I don't know about how this gem works and even know all methods / all this gem can do. Sincerely, I prefer to maintain your gem as "official", but if you really don't want that, I can stay with my repo. (After you accept the pull request I wanted delete my repo). Seriously, you decides. I will do what you said and I'm here if you want continue mainteining this gem. Again, thanks. Soon I come back here with the tips of your comment fixed. |
|
You can check my new Repo, supporting Rails 4, here: https://github.com/paladini/models-to-sql-rails |
Fix rails 4.1.6 compatibility issue
We already talked about that in "Issues". Basically this pull request give to this gem Rails 4.0 support - and some documentation was created too.