fixing reproducibility of lmeval tests #1220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
brian-dellabetta
commented
Mar 4, 2025
dsikka
previously approved these changes
Mar 4, 2025
brian-dellabetta
force-pushed
the
bdellabe/lmeval-test-bugfixes
branch
from
87dcc4c to
1f2ce00
Compare
brian-dellabetta
changed the title
dsikka
requested changes
Mar 5, 2025
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
brian-dellabetta
force-pushed
the
bdellabe/lmeval-test-bugfixes
branch
from
3429cc7 to
b91cd7b
Compare
horheynm
previously approved these changes
Mar 7, 2025
brian-dellabetta
changed the title
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
brian-dellabetta
dismissed stale reviews from rahul-tuli and horheynm
via
2d2e220
brian-dellabetta
force-pushed
the
bdellabe/lmeval-test-bugfixes
branch
from
b91cd7b to
2d2e220
Compare
kylesayrs
approved these changes
Mar 7, 2025
| "compressed-tensors" | ||
| if version_info.build_type == "release" | ||
| else "compressed-tensors-nightly", | ||
| "pillow", |
There was a problem hiding this comment.
Can we make this a dev dependency rather than a base dependency?
| @@ -2,6 +2,7 @@ cadence: weekly | |||
| model: Qwen/Qwen2-VL-2B-Instruct | |||
| model_class: TraceableQwen2VLForConditionalGeneration | |||
| scheme: FP8_DYNAMIC | |||
| seed: 42 #compressed model is sensitive to random seed | |||
There was a problem hiding this comment.
nit
Suggested change
| seed: 42 #compressed model is sensitive to random seed | |
| seed: 42 # compressed model is sensitive to random seed |
| @@ -73,6 +75,12 @@ def set_up(self): | |||
| self.quant_type = eval_config.get("quant_type") | |||
| self.save_dir = eval_config.get("save_dir") | |||
|
|
|||
| seed = eval_config.get("seed", None) | |||
| if seed is not None: | |||
There was a problem hiding this comment.
nit: use from transformers import set_seed
https://github.com/huggingface/transformers/blob/94ae1ba5b55e79ba766582de8a199d8ccf24a021/src/transformers/trainer_utils.py#L92
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
LM Eval weekly tests are failing, this resolves two issues
TEST PLAN:
no new src code