Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update test #773

Merged
merged 4 commits into from
Oct 4, 2024
Merged

update test #773

merged 4 commits into from
Oct 4, 2024

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Oct 3, 2024

SUMMARY:
"please provide a brief summary"

TEST PLAN:
"please outline how the changes were tested"

Copy link

github-actions bot commented Oct 3, 2024

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be another issue at play

ValueError: Trying to set a tensor of shape torch.Size([64, 1]) in "weight_scale" (which has shape torch.Size([64, 0])), this looks incorrect.

@dsikka
Copy link
Collaborator Author

dsikka commented Oct 3, 2024

Seems to be another issue at play

ValueError: Trying to set a tensor of shape torch.Size([64, 1]) in "weight_scale" (which has shape torch.Size([64, 0])), this looks incorrect.

Yup I was trying to figure out why this is showing up now. This PR fixes this. While doing that: neuralmagic/compressed-tensors#178 I decided to also enhance test coverage, hence this PR.

@mgoin mgoin merged commit 2362655 into main Oct 4, 2024
6 of 7 checks passed
@mgoin mgoin deleted the update_test branch October 4, 2024 15:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants