Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bugfix] Correct metrics calculations #878

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Oct 30, 2024

Purpose

  • Fix metrics calculations to use gigabytes and megabytes rather than gibibytes and mebibytes

Changes

  • Use correct gigabyte and megabyte sizes in metrics calculations
  • Rename get_layer_size_bytes to get_layer_size_mb

@kylesayrs kylesayrs requested a review from horheynm October 30, 2024 21:45
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs force-pushed the kylesayrs/fix-gb-calculation branch from 74801be to 85ecd4e Compare October 30, 2024 22:10
@kylesayrs kylesayrs self-assigned this Oct 31, 2024
@kylesayrs kylesayrs changed the title Correct metrics calculations [Bugfix] Correct metrics calculations Oct 31, 2024
@dsikka dsikka merged commit 4ad32a8 into main Nov 22, 2024
6 of 7 checks passed
@dsikka dsikka deleted the kylesayrs/fix-gb-calculation branch November 22, 2024 18:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants