-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Doc] Move PR template content to docs #10159
Conversation
In a recent PR, I saw another pattern that is probably common, but wasn't handled by this script. All of the template was removed except for the section that has the "click to expand" header. Signed-off-by: Russell Bryant <rbryant@redhat.com>
Move the bulk of the content from the PR template to the contributing section of the docs. Signed-off-by: Russell Bryant <rbryant@redhat.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though @simon-mo should make the final decision on this since it affects the PR template.
@simon-mo quick ping in case you missed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favour of this!
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: rickyx <rickyx@anyscale.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
b87d45d [CI/Build] Expand PR body cleanup to catch another pattern
d1cf025 [Doc] Move pr template content to docs
commit b87d45d
Author: Russell Bryant rbryant@redhat.com
Date: Fri Nov 8 08:38:40 2024 -0500
commit d1cf025
Author: Russell Bryant rbryant@redhat.com
Date: Fri Nov 8 09:24:39 2024 -0500