Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Doc] Move PR template content to docs #10159

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

russellb
Copy link
Member

@russellb russellb commented Nov 8, 2024

b87d45d [CI/Build] Expand PR body cleanup to catch another pattern
d1cf025 [Doc] Move pr template content to docs

commit b87d45d
Author: Russell Bryant rbryant@redhat.com
Date: Fri Nov 8 08:38:40 2024 -0500

[CI/Build] Expand PR body cleanup to catch another pattern

In a recent PR, I saw another pattern that is probably common, but
wasn't handled by this script. All of the template was removed except
for the section that has the "click to expand" header.

Signed-off-by: Russell Bryant <rbryant@redhat.com>

commit d1cf025
Author: Russell Bryant rbryant@redhat.com
Date: Fri Nov 8 09:24:39 2024 -0500

[Doc] Move pr template content to docs

Move the bulk of the content from the PR template to the contributing
section of the docs.

Signed-off-by: Russell Bryant <rbryant@redhat.com>

In a recent PR, I saw another pattern that is probably common, but
wasn't handled by this script. All of the template was removed except
for the section that has the "click to expand" header.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Move the bulk of the content from the PR template to the contributing
section of the docs.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Nov 8, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though @simon-mo should make the final decision on this since it affects the PR template.

@DarkLight1337
Copy link
Member

@simon-mo quick ping in case you missed it.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of this!

@simon-mo simon-mo merged commit 3e8d14d into vllm-project:main Nov 15, 2024
24 checks passed
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: rickyx <rickyx@anyscale.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci/build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants