Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[V1] Fix CI tests on V1 engine #10272

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[V1] Fix CI tests on V1 engine #10272

merged 2 commits into from
Nov 13, 2024

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Nov 12, 2024

This PR fixes the CI tests broken after #10245

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2024
@ywang96 ywang96 enabled auto-merge (squash) November 12, 2024 23:20
@ywang96 ywang96 disabled auto-merge November 12, 2024 23:56
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@khluu khluu enabled auto-merge (squash) November 13, 2024 00:00
@WoosukKwon WoosukKwon disabled auto-merge November 13, 2024 00:15
@WoosukKwon WoosukKwon merged commit 112fa0b into main Nov 13, 2024
15 of 29 checks passed
@WoosukKwon WoosukKwon deleted the v1-fix-ci branch November 13, 2024 00:17
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants