Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add default value to avoid Falcon crash (#5363) #10347

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Add default value to avoid Falcon crash (#5363) #10347

merged 3 commits into from
Nov 15, 2024

Conversation

wchen61
Copy link
Contributor

@wchen61 wchen61 commented Nov 15, 2024 •
edited by github-actions bot
Loading

FIX #5363 (link existing issues this PR will resolve)

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 15, 2024 •
edited
Loading

I think you should edit L253 instead of overwriting the existing value unconditionally.

DarkLight1337
DarkLight1337 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 15, 2024 06:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@wchen61
Add default value to avoid Falcon crash (vllm-project#5363)
842508a 
Signed-off-by: wchen61 <wchen61@foxmail.com>
@wchen61
[BugFix] Fix falcon config error (vllm-project#5363)
2567c49 
Signed-off-by: wchen61 <wchen61@foxmail.com>
@wchen61
Delete unnecessary line
3be9951 
Signed-off-by: wchen61 <wchen61@foxmail.com>
auto-merge was automatically disabled November 15, 2024 06:18

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 15, 2024 08:10
@DarkLight1337 DarkLight1337 merged commit 3d158cd into vllm-project:main Nov 15, 2024
51 checks passed
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@wchen61
Add default value to avoid Falcon crash (vllm-project#5363) (vllm-pro…
5c15c3a 
…ject#10347)

Signed-off-by: wchen61 <wchen61@foxmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@wchen61 @mfournioux
Add default value to avoid Falcon crash (vllm-project#5363) (vllm-pro…
a921a3c 
…ject#10347)

Signed-off-by: wchen61 <wchen61@foxmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
@wchen61 @rickyyx
Add default value to avoid Falcon crash (vllm-project#5363) (vllm-pro…
fc35bf1 
…ject#10347)

Signed-off-by: wchen61 <wchen61@foxmail.com>
Signed-off-by: rickyx <rickyx@anyscale.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@wchen61 @tlrmchlsmth
Add default value to avoid Falcon crash (vllm-project#5363) (vllm-pro…
cb92636 
…ject#10347)

Signed-off-by: wchen61 <wchen61@foxmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@wchen61
Add default value to avoid Falcon crash (vllm-project#5363) (vllm-pro…
9d75c99 
…ject#10347)

Signed-off-by: wchen61 <wchen61@foxmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Falcon fails if trust_remote_code=True
2 participants
@wchen61 @DarkLight1337