Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bugfix] Fix fully sharded LoRA bug #10352

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Nov 15, 2024

FIX #10342 (link existing issues this PR will resolve)

The issue arose because the code did not properly handle cases where all three lora_a
in MergedQKVParallelLinearWithShardedLora could be None. I also handled this issue in MergedColumnParallelLinearWithShardedLoRA.

BTW, fix small typo in worker.py

ping @DarkLight1337 also cc @xyang16 Thanks for catch this bug

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Can we add a test to avoid similar regressions?

@jeejeelee
Copy link
Collaborator Author

Can we add a test to avoid similar regressions?

I've been thinking about this.
current LoRA CI tests only run on a single GPU, which means many TP related logic cannot be verified in CI. Issues like this one cannot be catched when testing on a single GPU.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@DarkLight1337
Copy link
Member

We can add some LoRA tests to distributed tests.

@jeejeelee
Copy link
Collaborator Author

We can add some LoRA tests to distributed tests.

I'll do that, but it will probably take some time. Regarding this bug, my local testing shows no issues, including cases where qkv_proj, gate_proj, and up_proj are None.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's try to get this into the upcoming release first.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 15, 2024 08:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@DarkLight1337 DarkLight1337 merged commit 1d65ec7 into vllm-project:main Nov 15, 2024
64 of 66 checks passed
siddvenk pushed a commit to siddvenk/vllm that referenced this pull request Nov 18, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee deleted the full-shard-lora-bug branch November 19, 2024 14:16
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: rickyx <rickyx@anyscale.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Not able to run LLama3 LoRA with --fully-sharded-loras
2 participants