-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Bugfix] Fix fully sharded LoRA bug #10352
[Bugfix] Fix fully sharded LoRA bug #10352
Conversation
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Can we add a test to avoid similar regressions? |
I've been thinking about this. |
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
We can add some LoRA tests to distributed tests. |
I'll do that, but it will probably take some time. Regarding this bug, my local testing shows no issues, including cases where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's try to get this into the upcoming release first.
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: rickyx <rickyx@anyscale.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
FIX #10342 (link existing issues this PR will resolve)
The issue arose because the code did not properly handle cases where all three lora_a
in
MergedQKVParallelLinearWithShardedLora
could be None. I also handled this issue inMergedColumnParallelLinearWithShardedLoRA
.BTW, fix small typo in
worker.py
ping @DarkLight1337 also cc @xyang16 Thanks for catch this bug