Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Core] Add Sliding Window Support with Flashinfer #10462

Merged
merged 6 commits into from
Nov 21, 2024
Merged

[Core] Add Sliding Window Support with Flashinfer #10462

merged 6 commits into from
Nov 21, 2024

Conversation

pavanimajety
Copy link
Contributor

@pavanimajety pavanimajety commented Nov 19, 2024 •
edited by github-actions bot
Loading

Fix #9854

Tests following.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao self-requested a review November 19, 2024 19:59
@youkaichao
Copy link
Member

Looking forward to it! Please ping me when it is ready.

@mgoin mgoin self-requested a review November 19, 2024 21:21
@pavanimajety pavanimajety marked this pull request as ready for review November 19, 2024 23:41
@pavanimajety
Copy link
Contributor Author

/ready

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 20, 2024
mgoin
mgoin approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI, thanks cc @youkaichao

youkaichao
youkaichao approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great contribution!

@youkaichao youkaichao enabled auto-merge (squash) November 20, 2024 21:45
@pavanimajety
SWA
4bbf10e 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
@pavanimajety
SWA prefill/decode update
484c7bc 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
@pavanimajety
Fix window size for flashinfer
a60bb6d 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
@pavanimajety
Fix formatting issues
a9c2219 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
@pavanimajety
Add flashinfer backend to sliding_window test
f328bc5 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
@pavanimajety
NFC: Fix minor lint
f4b68da 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
auto-merge was automatically disabled November 21, 2024 00:30

Head branch was pushed to by a user without write access

@pavanimajety
Copy link
Contributor Author

Just rebased, seems like a few fixes went in main. The test failures seem unrelated to this PR

@youkaichao youkaichao merged commit 6c1208d into vllm-project:main Nov 21, 2024
52 checks passed
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@pavanimajety @tlrmchlsmth
[Core] Add Sliding Window Support with Flashinfer (vllm-project#10462)
df72420 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@pavanimajety @mfournioux
[Core] Add Sliding Window Support with Flashinfer (vllm-project#10462)
ab0551f 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@pavanimajety
[Core] Add Sliding Window Support with Flashinfer (vllm-project#10462)
38cf1f8 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 10, 2025
@pavanimajety @anko-intel
[Core] Add Sliding Window Support with Flashinfer (vllm-project#10462)
955f789 
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[help wanted]: add sliding window support for flashinfer
3 participants
@pavanimajety @youkaichao @mgoin