[Bugfix]: Clamp -inf logprob values in prompt_logprobs
#11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
rafvasq
changed the title
-inf logprob values in prompt_logprobs-inf logprob values in prompt_logprobs
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
rafvasq
force-pushed
the
investigate-top-k
branch
from
058f878 to
32f8ba8
Compare
github-actions
bot
added
the
ready
Akshat-Tripathi
pushed a commit
to krai/vllm
that referenced
this pull request
Dec 12, 2024
…t#11073) Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Akshat Tripathi <akshat@krai.ai>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
…t#11073) Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…t#11073) Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
This was referenced Feb 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logprobs with an
-infvalue are clamped to-9999.0in other parts of the code but not here, resulting in a JSON compliance error in cases where thetop_ksampling parameter is used too.Fixes #10234