Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PaliGemma 2 support #11142

Merged
merged 1 commit into from
Dec 13, 2024
Merged

PaliGemma 2 support #11142

merged 1 commit into from
Dec 13, 2024

Conversation

janimo
Copy link
Contributor

@janimo janimo commented Dec 12, 2024

Minor changes to support PaliGemma 2.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@janimo janimo force-pushed the paligemma-2 branch 2 times, most recently from 4cb5bf2 to 6779a75 Compare December 12, 2024 16:51
@janimo janimo marked this pull request as ready for review December 12, 2024 17:14
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs/source/models/supported_models.rst to state the support of paligemma2 explicitly as well?

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 12, 2024
@janimo
Copy link
Contributor Author

janimo commented Dec 12, 2024

thanks for the review, I have force-pushed a new commit including the requested changes.

Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Isotr0py Isotr0py enabled auto-merge (squash) December 13, 2024 05:02
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@Isotr0py Isotr0py merged commit 7cd7409 into vllm-project:main Dec 13, 2024
68 checks passed
@exceedzhang
Copy link

WX20241213-201412@2x
The large language model 'google/paligemma2-10b-pt-896' that you are currently using has experienced inference failure.

@janimo
Copy link
Contributor Author

janimo commented Dec 13, 2024

@exceedzhang I have not tested that particular model size, nor the serving interface, just the 3b models via the direct llm.Engine() API.
Do the smaller PaliGemma2 models and PaliGemma 1 models work for you in the same setup?

@exceedzhang
Copy link

WX20241214-201958@2x
WX20241214-202032@2x
The same mistake!

@janimo
Copy link
Contributor Author

janimo commented Dec 14, 2024

@exceedzhang If it happens with paligemma 1 models too, please file an issue for it with the exact command to reproduce it.

BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@janimo janimo deleted the paligemma-2 branch January 4, 2025 10:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants