[Bugfix][Build/CI] Fix sparse CUTLASS compilation on CUDA [12.0, 12.2) #11311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
tlrmchlsmth
force-pushed
the
fix_sparse_cutlass_compilation
branch
from
4b8652d to
fbc974d
Compare
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
tlrmchlsmth
requested review from
mgoin,
robertgshaw2-redhat and
WoosukKwon
as code owners
mgoin
approved these changes
Dec 18, 2024
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
mzusman
pushed a commit
to mzusman/vllm
that referenced
this pull request
Mar 12, 2025
vllm-project#11311) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking against CUDA 12.0 when we should have been checking for 12.2
https://github.com/NVIDIA/cutlass/blob/e1cd8c7866dd6de02b66a89879795e7d7301aacc/examples/62_hopper_sparse_gemm/62_hopper_sparse_gemm.cu#L553-L559
I also plumbed up a
cutlass_sparse_scaled_mm_supportedfunction so we can fail more gracefully if the kernel is not supported.