[CI] Expand test_guided_generate to test all backends #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoin <michael@neuralmagic.com>
mgoin
requested review from
DarkLight1337,
robertgshaw2-redhat and
simon-mo
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
DarkLight1337
approved these changes
Dec 19, 2024
github-actions
bot
added
the
ready
ZenPuzzle
pushed a commit
to ZenPuzzle/vllm
that referenced
this pull request
Dec 25, 2024
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…1313) Signed-off-by: mgoin <michael@neuralmagic.com> Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
mzusman
pushed a commit
to mzusman/vllm
that referenced
this pull request
Mar 12, 2025
…1313) Signed-off-by: mgoin <michael@neuralmagic.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only testing the default structured output backend, so we should expand to explicitly call all backends. This revealed some lack of support in outlines for json_object and lm-format-enforcer for regex patterns in json schemas.
I also found some of the tests are flaky for some backends due to bad model output (many many newlines or filler tokens), so using a higher quality Qwen2.5 model helped