[misc] add early error message for custom ops #11355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youkaichao <youkaichao@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
lucas-tucker
pushed a commit
to lucas-tucker/vllm-lucas-tucker
that referenced
this pull request
Dec 21, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: lucast2021 <lucast2021@headroyce.org>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
mzusman
pushed a commit
to mzusman/vllm
that referenced
this pull request
Mar 12, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported by @joschu-anthropic
I think it might also solve #2021 (comment) , cc @yajuvendrarawat