[Core] Make raw_request optional in ServingCompletion #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
schoennenbeck
force-pushed
the
feature/make-raw_request-optional
branch
from
ee17c2f to
e2a9613
Compare
|
Could you elaborate on the use case for this? |
|
DarkLight1337
approved these changes
Jan 28, 2025
DarkLight1337
added
the
ready
|
I'll enable auto-merge once you fix the typo. |
Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
Thanks for the super quick turn around! |
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Jan 30, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Feb 2, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com> Signed-off-by: Isotr0py <2037008807@qq.com>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Feb 7, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
GWS0428
pushed a commit
to GWS0428/VARserve
that referenced
this pull request
Feb 12, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
kerthcet
pushed a commit
to kerthcet/vllm
that referenced
this pull request
Feb 21, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Mar 5, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com> Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar
pushed a commit
to Said-Akbar/vllm-rocm
that referenced
this pull request
Mar 7, 2025
…2503) Signed-off-by: Sebastian Schönnenbeck <sebastian.schoennenbeck@comma-soft.com> Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply ports the logic that is already used in
OpenAIServingChattoOpenAIServingCompletionto make passing theraw_requestoptional.