Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Misc][MoE] add Deepseek-V3 moe tuning support #12558

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

divakar-amd
Copy link
Contributor

@divakar-amd divakar-amd commented Jan 29, 2025

  • add moe tuning support for DeepSeek-V3
  • add arg.trust_remote_code for better user exeperience. Use --trut_remote_code when tuning for deepseek

Currently, DeepSeek-V3 runs into error when using graph-mode. This has been handled by forcing 'eager-mode' as a workaround. Hence, bypassing graph capture in the moe tuning script for deepseek-v3
- use a boolean variable use_graphs to selectively diasble graph capture for DeepSeek-V3
- get_default_config was missing is_marlin flag. Set it to False as default.

Bypass graph capture in the moe tuning script for deepseek-v3

Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Divakar Verma <divakar.verma@amd.com>
@divakar-amd divakar-amd force-pushed the fix_deepseekv3_moeTuning branch from 6e40b95 to edda3cb Compare January 29, 2025 17:28
@divakar-amd divakar-amd changed the title Deepseek-V3 moe tuning workaround [Misc][MoE] add Deepseek-V3 moe tuning support Jan 29, 2025
@divakar-amd divakar-amd marked this pull request as ready for review January 29, 2025 18:08
@mgoin mgoin self-requested a review January 29, 2025 18:09
@tlrmchlsmth tlrmchlsmth self-requested a review January 29, 2025 18:15
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. This looks good to me.

Note: I ran into a couple of somewhat orthogonal issues when trying it out, so threw up #12562 to address them

@mgoin
Copy link
Member

mgoin commented Jan 29, 2025

LGTM for this part, but we still need to add support for the block fp8 config

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 29, 2025
@mgoin mgoin enabled auto-merge (squash) January 29, 2025 22:58
@mgoin mgoin merged commit 1c1bb0b into vllm-project:main Jan 30, 2025
44 checks passed
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants