-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix device return is bytecode instead of str #12635
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Should we also ensure that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @youkaichao This is caused by old version of pynvml. We should improve the error message to notify users to update the library version instead of just printing out a warning message. |
Closing in favour of #12636 |
Pull request was closed
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Felix Marty <felmarty@amd.com>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Linkun Chen <github@lkchen.net>
fixes problems like vllm-project#12635 and vllm-project#12636 and vllm-project#12565 --------- Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: saeediy <saidakbarp@gmail.com>
File "/host/vllm/vllm/engine/arg_utils.py", line 1293, in _override_v1_engine_args
if "h100" in device_name or "h200" in device_name:
TypeError: a bytes-like object is required, not 'str'