Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix device return is bytecode instead of str #12635

Closed

Conversation

CXIAAAAA
Copy link

@CXIAAAAA CXIAAAAA commented Feb 1, 2025

File "/host/vllm/vllm/engine/arg_utils.py", line 1293, in _override_v1_engine_args
if "h100" in device_name or "h200" in device_name:
TypeError: a bytes-like object is required, not 'str'

Copy link

github-actions bot commented Feb 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 1, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 1, 2025 00:56
@hmellor
Copy link
Member

hmellor commented Feb 1, 2025

Should we also ensure that get_device_name() always returns a string? So that we don't have to make this patch anywhere else that it's called?

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @hmellor as this is the same root issue as #12565

@DarkLight1337
Copy link
Member

cc @youkaichao

This is caused by old version of pynvml. We should improve the error message to notify users to update the library version instead of just printing out a warning message.

@hmellor
Copy link
Member

hmellor commented Feb 1, 2025

Closing in favour of #12636

@hmellor hmellor closed this Feb 1, 2025
auto-merge was automatically disabled February 1, 2025 11:19

Pull request was closed

youkaichao added a commit that referenced this pull request Feb 3, 2025
fixes problems like #12635 and
#12636 and
#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
sahelib25 pushed a commit to krai/vllm that referenced this pull request Feb 3, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
fxmarty-amd pushed a commit to fxmarty-amd/vllm that referenced this pull request Feb 7, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
fixes problems like vllm-project#12635 and
vllm-project#12636 and
vllm-project#12565

---------

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants