Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Build][AMD] Fix the hashbang in the hipify script #12698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gshtras
Copy link
Contributor

@gshtras gshtras commented Feb 3, 2025

No description provided.

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 3, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 3, 2025 16:07
@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2025
@mgoin
Copy link
Member

mgoin commented Feb 3, 2025

We should fix this in the larger correction PR #12694

@hongxiayang
Copy link
Collaborator

FYI: there was a similar PR for this fix: #12665

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this in the larger correction PR #12694

Yeah, #12694 needs to be merged because otherwise, if you merge just the script fix, pre-commit will break it again right away.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants