-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support Pixtral-Large HF by using llava multimodal_projector_bias config #12710
Support Pixtral-Large HF by using llava multimodal_projector_bias config #12710
Conversation
Signed-off-by: mgoin <michael@neuralmagic.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good catch
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com> Signed-off-by: Felix Marty <felmarty@amd.com>
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com>
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com>
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com>
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com> Signed-off-by: Linkun Chen <github@lkchen.net>
…fig (vllm-project#12710) Signed-off-by: mgoin <michael@neuralmagic.com> Signed-off-by: saeediy <saidakbarp@gmail.com>
Thanks to @shubhra for finding this issue. We need to port the addition of
multimodal_projector_bias
in most llava-style configs from huggingface/transformers#34801 to support loading the HF-version of Pixtral-Large