-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Misc] Remove dangling references to SamplingType.BEAM
#13402
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup!
SamplingType.BEAM
SamplingType.BEAM
…t#13402) Signed-off-by: Linkun Chen <github@lkchen.net>
…t#13402) Signed-off-by: saeediy <saidakbarp@gmail.com>
SamplingType.BEAM
was removed fromvllm/sampling_params.py
in #9105This PR removes two remaining references to
SamplingType.BEAM
and the dead code that cannot be reached with these references removed.Closes #13355.