Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Misc] Remove dangling references to SamplingType.BEAM #13402

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Feb 17, 2025

SamplingType.BEAM was removed from vllm/sampling_params.py in #9105

This PR removes two remaining references to SamplingType.BEAM and the dead code that cannot be reached with these references removed.

Closes #13355.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup!

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 17, 2025
@DarkLight1337 DarkLight1337 changed the title Remove dangling references to SamplingType.BEAM [Misc] Remove dangling references to SamplingType.BEAM Feb 17, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 17, 2025 13:58
@simon-mo simon-mo merged commit efbe854 into vllm-project:main Feb 18, 2025
58 of 63 checks passed
@hmellor hmellor deleted the fix-missed-beam branch February 18, 2025 08:04
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sampler uses non-existing SamplingType.BEAM enum member
3 participants