Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ROCm] fix get_device_name for rocm #13438

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

divakar-amd
Copy link
Contributor

@divakar-amd divakar-amd commented Feb 18, 2025

Use amd-smi to get the device name for AMD GPUs.

Tested using:

VLLM_ENABLE_V1_MULTIPROCESSING=0 VLLM_USE_V1=1 python benchmark_latency.py --model Mixtral-8x7B-v0.1/ --load-format dummy -tp 8

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Divakar Verma <divakar.verma@amd.com>
@divakar-amd divakar-amd force-pushed the fix_device_name_amdsmi branch from 76fb663 to 67308e4 Compare February 18, 2025 00:16
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 02:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@DarkLight1337 DarkLight1337 merged commit 7c7adf8 into vllm-project:main Feb 18, 2025
57 checks passed
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants